Remove unused macro rules #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
reviewed
May 16, 2022
There was a problem hiding this comment.
Thanks for the PR! This lint is now allowed by default (rust-lang/rust#97032), but I think addressing some of them is reasonable.
crossbeam-channel/tests/golang.rs
Outdated
Comment on lines
225
to
227
| (@parse $($tail:tt)*) => { | ||
| compile_error!("invalid `go!` syntax") | ||
| }; |
There was a problem hiding this comment.
This is a false positive since this rule exists to be "unused".
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
unused_macro_ruleslint that recently landed in nightly breaks CI builds.This fix removes unused macro arms in tests.